Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 477343002: Revert "Add IPC benchmarking API to Blink TestRunner" (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert "Add IPC benchmarking API to Blink TestRunner" (patchset #3 of https://codereview.chromium.org/478483005/ , commit 345949391e63d5237326eb16771ae48af0a2e881.) Reason for revert: Breaks fast/dom/Window LayoutTests http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35621 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/10059 Original issue's description: > Add IPC benchmarking API to Blink TestRunner > > This add an window.testRunner API that sends do-nothing IPC message > roundtrip. This API can be used to build IPC benchmark using > JavaScript. > > TEST=none (Will add blink-side LayoutTest once this is landed) > BUG=402185 > R=darin@chromium.org, jam@chromim.org, jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290063 TBR=morrita@chromium.org, darin@chromium.org, jochen@chromium.org, jam@chromium.org BUG=402185 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -189 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/webkit_test_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/shell/common/shell_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
D content/shell/renderer/ipc_echo.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/shell/renderer/ipc_echo.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestDelegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +0 lines, -40 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 4 chunks +0 lines, -6 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 4 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
6 years, 4 months ago (2014-08-16 16:08:57 UTC) #1
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-16 16:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/477343002/1
6 years, 4 months ago (2014-08-16 16:09:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (1) as 290153
6 years, 4 months ago (2014-08-16 16:09:51 UTC) #4
Hajime Morrita
6 years, 4 months ago (2014-08-18 19:32:53 UTC) #5
Message was sent while issue was closed.
Oops. Thanks for taking care of it.

Powered by Google App Engine
This is Rietveld 408576698