Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: pkg/analysis_server/test/protocol_test.dart

Issue 477323005: Use generated classes to create requests in analysis server unit tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/protocol_test.dart
diff --git a/pkg/analysis_server/test/protocol_test.dart b/pkg/analysis_server/test/protocol_test.dart
index 855fed99bbb57b7c68811bcb0300fad71d850443..c46249bd6a366558fffd70999589fa246807ce5b 100644
--- a/pkg/analysis_server/test/protocol_test.dart
+++ b/pkg/analysis_server/test/protocol_test.dart
@@ -503,8 +503,7 @@ class RequestTest {
}
void test_fromJson_withParams() {
- Request original = new Request('one', 'aMethod');
- original.setParameter('foo', 'bar');
+ Request original = new Request('one', 'aMethod', {'foo': 'bar'});
String json = JSON.encode(original.toJson());
Request request = new Request.fromString(json);
expect(request.id, equals('one'));
@@ -515,15 +514,13 @@ class RequestTest {
void test_getRequiredParameter_defined() {
String name = 'name';
String value = 'value';
- Request request = new Request('0', '');
- request.setParameter(name, value);
+ Request request = new Request('0', '', {name: value});
expect(request.getRequiredParameter(name).datum, equals(value));
}
void test_getRequiredParameter_null() {
String name = 'name';
- Request request = new Request('0', '');
- request.setParameter(name, null);
+ Request request = new Request('0', '', {name: null});
expect(request.getRequiredParameter(name).datum, equals(null));
}
@@ -542,8 +539,7 @@ class RequestTest {
}
void test_toJson_withParams() {
- Request request = new Request('one', 'aMethod');
- request.setParameter('foo', 'bar');
+ Request request = new Request('one', 'aMethod', {'foo': 'bar'});
expect(request.toJson(), equals({
Request.ID: 'one',
Request.METHOD: 'aMethod',
« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | pkg/analysis_server/test/search/element_references_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698