chrome/browser/ui/tab_helpers.cc - Issue 477263003: pdf: Create a separate component for using the pdf pepper plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 477263003: pdf: Create a separate component for using the pdf pepper plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h » ('j') | components/pdf/renderer/ppb_pdf_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 7e73f749c8cfb4497ba2483afb3fdad39b09aa39..797bb3af6cc18848227beabf3ff625276421d288 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"

#include "chrome/browser/ui/find_bar/find_tab_helper.h"

#include "chrome/browser/ui/navigation_correction_tab_observer.h"

+#include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"

#include "chrome/browser/ui/prefs/prefs_tab_helper.h"

#include "chrome/browser/ui/search/search_tab_helper.h"

#include "chrome/browser/ui/tab_contents/core_tab_helper.h"

@@ -43,12 +44,12 @@

#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"

#include "chrome/browser/ui/hung_plugin_tab_helper.h"

#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"

-#include "chrome/browser/ui/pdf/pdf_tab_helper.h"

#include "chrome/browser/ui/sad_tab_helper.h"

#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"

#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"

#include "chrome/browser/ui/zoom/zoom_controller.h"

+#include "components/pdf/browser/pdf_web_contents_helper.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

#endif // defined(OS_ANDROID)

@@ -164,7 +165,10 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

ExternalProtocolObserver::CreateForWebContents(web_contents);

HungPluginTabHelper::CreateForWebContents(web_contents);

ManagePasswordsUIController::CreateForWebContents(web_contents);

- PDFTabHelper::CreateForWebContents(web_contents);

+ pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(

+ web_contents,

+ scoped_ptr<pdf::PDFWebContentsHelperClient>(

+ new ChromePDFWebContentsHelperClient()));

PermissionBubbleManager::CreateForWebContents(web_contents);

PluginObserver::CreateForWebContents(web_contents);

SadTabHelper::CreateForWebContents(web_contents);