Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3536)

Unified Diff: chrome/chrome_renderer.gypi

Issue 477263003: pdf: Create a separate component for using the pdf pepper plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_renderer.gypi
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi
index c5320ec72b96d94a740c845a079d814917d944d5..32429cd7196c266352c6a062bf7b80c349ae5645 100644
--- a/chrome/chrome_renderer.gypi
+++ b/chrome/chrome_renderer.gypi
@@ -208,8 +208,6 @@
'renderer/pepper/pepper_shared_memory_message_filter.h',
'renderer/pepper/pepper_uma_host.cc',
'renderer/pepper/pepper_uma_host.h',
- 'renderer/pepper/ppb_pdf_impl.cc',
- 'renderer/pepper/ppb_pdf_impl.h',
],
# For safe_browsing==1 or safe_browsing==2.
'chrome_renderer_basic_safe_browsing_sources': [
@@ -261,6 +259,10 @@
'renderer/printing/print_web_view_helper_linux.cc',
'renderer/printing/print_web_view_helper_mac.mm',
],
+ 'chrome_renderer_full_printing_sources': [
Lei Zhang 2014/08/26 22:41:30 You need to update the corresponding BUILD.gn file
sadrul 2014/08/27 00:09:52 Done.
+ 'renderer/pepper/chrome_pdf_print_delegate.cc',
+ 'renderer/pepper/chrome_pdf_print_delegate.h',
+ ],
},
'targets': [
{
@@ -320,6 +322,7 @@
'<@(chrome_renderer_plugin_sources)',
],
'dependencies': [
+ '../components/components.gyp:pdf_pepper_renderer',
'../ppapi/ppapi_internal.gyp:ppapi_host',
'../ppapi/ppapi_internal.gyp:ppapi_proxy',
'../ppapi/ppapi_internal.gyp:ppapi_ipc',
@@ -379,7 +382,12 @@
['enable_printing!=0', {
'sources': [
'<@(chrome_renderer_printing_sources)',
- ]
+ ],
+ 'conditions': [
Lei Zhang 2014/08/26 22:41:30 I'd just put enable_printing==1 at the same level
sadrul 2014/08/27 00:09:51 Done.
+ ['enable_printing==1', {
+ 'sources': [ '<@(chrome_renderer_full_printing_sources)' ],
+ },],
+ ],
}],
['win_pdf_metafile_for_printing==1', {
'sources': [

Powered by Google App Engine
This is Rietveld 408576698