Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 477263003: pdf: Create a separate component for using the pdf pepper plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
index 8175022edca475e6ede42075a725f5070540ffb0..5c5e1cb7987849b1d5a9f0fef1c2558a9a6f484f 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
@@ -9,9 +9,10 @@
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/guest_view/web_view/web_view_constants.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
-#include "chrome/browser/ui/pdf/pdf_tab_helper.h"
+#include "chrome/browser/ui/pdf/chrome_pdf_tab_helper_delegate.h"
#include "chrome/browser/ui/zoom/zoom_controller.h"
#include "chrome/common/chrome_version_info.h"
+#include "components/pdf/browser/pdf_tab_helper.h"
#include "components/renderer_context_menu/context_menu_delegate.h"
#include "content/public/common/page_zoom.h"
@@ -84,7 +85,9 @@ void ChromeWebViewGuestDelegate::OnAttachWebViewHelpers(
printing::PrintViewManagerBasic::CreateForWebContents(contents);
#endif // defined(ENABLE_FULL_PRINTING)
#endif // defined(ENABLE_PRINTING)
- PDFTabHelper::CreateForWebContents(contents);
+ pdf::PDFTabHelper::CreateForWebContentsWithDelegate(
+ contents,
+ scoped_ptr<pdf::PDFTabHelperDelegate>(new ChromePDFTabHelperDelegate()));
}
void ChromeWebViewGuestDelegate::OnDidCommitProvisionalLoadForFrame(

Powered by Google App Engine
This is Rietveld 408576698