pdf: Create a separate component for using the pdf pepper plugin.

components/pdf/browser/open_pdf_in_reader_prompt_delegate.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.

[blundell, 2014/08/27 09:12:32]

nit: personally i wouldn't change this (same comment applies if there are other
copied files that you've done this for).

[sadrul, 2014/08/27 11:49:57]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_PDF_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_
-#define CHROME_BROWSER_UI_PDF_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_
+#ifndef COMPONENTS_PDF_BROWSER_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_
+#define COMPONENTS_PDF_BROWSER_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_
 
 #include "base/strings/string16.h"
 
 namespace content {
 struct LoadCommittedDetails;
 }
 
+namespace pdf {
+
 class OpenPDFInReaderPromptDelegate {

[blundell, 2014/08/27 09:12:32]

nit: for this class and the other Delegate class, the naming convention in
components is to use Client rather than Delegate for interfaces that are
implemented by the embedder.

[sadrul, 2014/08/27 11:49:57]

How strongly do you feel about this? Since this is relocation of existing code
(and there are a number of *Delegate interfaces in other components, e.g.
autofill, precache, web_modal, translate etc.), I would rather keep this
unchanged.

[blundell, 2014/08/27 12:24:48]

I feel pretty strongly about it. The ones that you point out are either (a)
vestiges from before this naming convention was crystallized (e.g.,
visitedlink_delegate.h) or (b) not interfaces that are implemented by the
embedder (e.g., translate_ui_delegate.h, autofill_external_delegate.h). Now that
the convention is in place, I'd rather not muddy the waters further.

  public:
   virtual ~OpenPDFInReaderPromptDelegate() {}
 
   virtual base::string16 GetMessageText() const = 0;
 
   virtual base::string16 GetAcceptButtonText() const = 0;
 
   virtual base::string16 GetCancelButtonText() const = 0;
 
   virtual bool ShouldExpire(
       const content::LoadCommittedDetails& details) const = 0;
 
   virtual void Accept() = 0;
 
   virtual void Cancel() = 0;
 };
 
-#endif  // CHROME_BROWSER_UI_PDF_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_
+}  // namespace pdf
+
+#endif  // COMPONENTS_PDF_BROWSER_OPEN_PDF_IN_READER_PROMPT_DELEGATE_H_