Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 477253002: Revert of Move sqlite_channel_id_store from chrome/browser/net to net/extras. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move sqlite_channel_id_store from chrome/browser/net to net/extras. (patchset #26 of https://codereview.chromium.org/381073002/) Reason for revert: Closed the tree on failing net_unittests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=32912 Original issue's description: > Move sqlite_channel_id_store from chrome/browser/net to net/extras. > Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store. > > TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest* > TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore* > > BUG=397545 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289996 TBR=mef@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1177 lines, -1599 lines) Patch
D chrome/browser/net/quota_policy_channel_id_store.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/net/quota_policy_channel_id_store.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
A chrome/browser/net/sqlite_channel_id_store.h View 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/net/sqlite_channel_id_store.cc View 1 chunk +641 lines, -0 lines 0 comments Download
A chrome/browser/net/sqlite_channel_id_store_unittest.cc View 1 chunk +473 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
D net/extras/sqlite/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D net/extras/sqlite/sqlite_channel_id_store.h View 1 chunk +0 lines, -61 lines 0 comments Download
D net/extras/sqlite/sqlite_channel_id_store.cc View 1 chunk +0 lines, -636 lines 0 comments Download
D net/extras/sqlite/sqlite_channel_id_store_unittest.cc View 1 chunk +0 lines, -510 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -14 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
miu
Created Revert of Move sqlite_channel_id_store from chrome/browser/net to net/extras.
6 years, 4 months ago (2014-08-15 22:51:59 UTC) #1
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-15 22:53:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/477253002/1
6 years, 4 months ago (2014-08-15 22:56:37 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 23:02:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (1) as 290038

Powered by Google App Engine
This is Rietveld 408576698