DescriptionRevert of Minor cleanup of EnrollmentHandlerChromeOS. (patchset #7 of https://codereview.chromium.org/465413002/)
Reason for revert:
Two of the bots have been failed.
http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29/builds/1102
http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%29/builds/1066
The error message looks like related to this cl.
Original issue's description:
> Minor cleanup of EnrollmentHandlerChromeOS.
>
> Rename private methods for consistency: Start*() for something that invokes
> an async operation and Handle*() for something that gets called back by such
> an operation. That leaves On*() reserved for observers. Also update some
> comments. Lastly, use the current state key from the parameter passed to
> HandleStateKeysResult() instead of requesting it again from the broker (line
> 222).
>
> EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on
> unreached code paths. Generally, remove some obsolete instances of
> NOTREACHED() after switches over enums: The compiler ensures that all enum
> values are covered, there's no need to complicate the code by checking the
> same thing again.
>
> BUG=none
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841
TBR=joaodasilva@chromium.org,tnagel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290853
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|