Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 477243003: Revert of Minor cleanup of EnrollmentHandlerChromeOS. (Closed)

Created:
6 years, 4 months ago by jennyz
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Minor cleanup of EnrollmentHandlerChromeOS. (patchset #7 of https://codereview.chromium.org/465413002/) Reason for revert: Two of the bots have been failed. http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29/builds/1102 http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%29/builds/1066 The error message looks like related to this cl. Original issue's description: > Minor cleanup of EnrollmentHandlerChromeOS. > > Rename private methods for consistency: Start*() for something that invokes > an async operation and Handle*() for something that gets called back by such > an operation. That leaves On*() reserved for observers. Also update some > comments. Lastly, use the current state key from the parameter passed to > HandleStateKeysResult() instead of requesting it again from the broker (line > 222). > > EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on > unreached code paths. Generally, remove some obsolete instances of > NOTREACHED() after switches over enums: The compiler ensures that all enum > values are covered, there's no need to complicate the code by checking the > same thing again. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841 TBR=joaodasilva@chromium.org,tnagel@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -106 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 4 chunks +50 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.h View 1 chunk +18 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 12 chunks +43 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/policy/server_backed_state_keys_broker.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jennyz
Created Revert of Minor cleanup of EnrollmentHandlerChromeOS.
6 years, 4 months ago (2014-08-20 16:55:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/477243003/1
6 years, 4 months ago (2014-08-20 16:56:47 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 16:58:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 290853

Powered by Google App Engine
This is Rietveld 408576698