Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 477203002: NaCl documentation: update release notes for Chrome 38 (Closed)

Created:
6 years, 4 months ago by JF
Modified:
6 years, 3 months ago
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/bc27da6a868529c12311afcc54abc54126bab3be Cr-Commit-Position: refs/heads/master@{#292213}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Revert needless doc_generated/community/index.html change. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M native_client_sdk/doc_generated/community/index.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/distributing.html View 1 chunk +7 lines, -13 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 19 chunks +28 lines, -21 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
JF
6 years, 4 months ago (2014-08-15 21:01:38 UTC) #1
binji
https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 4 months ago (2014-08-15 21:11:58 UTC) #2
JF
https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 4 months ago (2014-08-15 21:19:25 UTC) #3
binji
https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 4 months ago (2014-08-15 21:24:57 UTC) #4
jpmedley
lgtm
6 years, 4 months ago (2014-08-18 15:26:05 UTC) #5
dmichael (off chromium)
lgtm lgtm from pepper perspective
6 years, 4 months ago (2014-08-18 15:52:38 UTC) #6
JF
The CQ bit was checked by jfb@chromium.org
6 years, 3 months ago (2014-08-27 20:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/477203002/40001
6 years, 3 months ago (2014-08-27 20:23:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 20:24:57 UTC) #9
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 20:24:58 UTC) #10
JF
Committed patchset #3 (id:40001) to pending queue manually as b60bb0e.
6 years, 3 months ago (2014-08-27 20:40:59 UTC) #11
JF
https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/477203002/diff/1/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 3 months ago (2014-08-27 20:50:18 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:43 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc27da6a868529c12311afcc54abc54126bab3be
Cr-Commit-Position: refs/heads/master@{#292213}

Powered by Google App Engine
This is Rietveld 408576698