extensions/renderer/set_icon_natives.h - Issue 477193003: Refactor setIcon to allow for more general use of imageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/set_icon_natives.h

Issue 477193003: Refactor setIcon to allow for more general use of imageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes, reworked conversion logic Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/set_icon.js ('K') | « extensions/renderer/resources/set_icon.js ('k') | extensions/renderer/set_icon_natives.cc » ('j') | extensions/renderer/set_icon_natives.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/set_icon_natives.h

diff --git a/extensions/renderer/set_icon_natives.h b/extensions/renderer/set_icon_natives.h

index e5129dd976b3690985a6b2f60f320774ae849540..5b183bacf0873b948adcc0c26ffd489b7ba07e96 100644

--- a/extensions/renderer/set_icon_natives.h

+++ b/extensions/renderer/set_icon_natives.h

@@ -24,10 +24,10 @@ class SetIconNatives : public ObjectBackedNativeHandler {

private:

bool ConvertImageDataToBitmapValue(const v8::Local<v8::Object> image_data,

- base::Value** bitmap_value);

+ v8::Local<v8::Value>* image_data_bitmap);

bool ConvertImageDataSetToBitmapValueSet(

const v8::FunctionCallbackInfo<v8::Value>& args,

- base::DictionaryValue* bitmap_value);

+ v8::Local<v8::Object>* bitmap_set_value);

void SetIconCommon(const v8::FunctionCallbackInfo<v8::Value>& args);

RequestSender* request_sender_;