chrome/renderer/resources/extensions/page_action_custom_bindings.js - Issue 477193003: Refactor setIcon to allow for more general use of imageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 477193003: Refactor setIcon to allow for more general use of imageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added page action binding, cleaned up setIcon logic Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/browser_action_custom_bindings.js ('k') | extensions/renderer/resources/set_icon.js » ('j') | extensions/renderer/resources/set_icon.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/page_action_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/page_action_custom_bindings.js b/chrome/renderer/resources/extensions/page_action_custom_bindings.js

index 97a308eba6c8270c4a4b7a03b029c1e6ba318b50..b4f92c68169caa6c9dc36b92025a875e2f74d1e1 100644

--- a/chrome/renderer/resources/extensions/page_action_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/page_action_custom_bindings.js

@@ -7,13 +7,15 @@

var binding = require('binding').Binding.create('pageAction');

var setIcon = require('setIcon').setIcon;

+var sendRequest = require('sendRequest').sendRequest;

binding.registerCustomHook(function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

apiFunctions.setHandleRequest('setIcon', function(details, callback) {

- setIcon(details, callback, this.name, this.definition.parameters,

- 'page action');

+ setIcon(details, function(args) {

+ sendRequest(this.name, [args, callback], this.definition.parameters);

+ }.bind(this));

});