Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4263)

Unified Diff: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js

Issue 477193003: Refactor setIcon to allow for more general use of imageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar minor changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js b/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
index 91d02a62f353c6745a93da3d6a651814c411a64c..e07a9cdc6c8b3d445e106b425fb77c72d452e1f7 100644
--- a/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
@@ -9,13 +9,15 @@
var binding = require('binding').Binding.create('systemIndicator');
var setIcon = require('setIcon').setIcon;
+var sendRequest = require('sendRequest').sendRequest;
binding.registerCustomHook(function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setHandleRequest('setIcon', function(details, callback) {
- setIcon(details, callback, this.name, this.definition.parameters,
- 'system indicator');
+ setIcon(details, function(args) {
+ sendRequest(this.name, [args, callback], this.definition.parameters);
+ }.bind(this));
});
});
« no previous file with comments | « chrome/renderer/resources/extensions/page_action_custom_bindings.js ('k') | extensions/renderer/resources/set_icon.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698