Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 477193003: Refactor setIcon to allow for more general use of imageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor changes, reworked conversion logic Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the pageAction API. 5 // Custom binding for the pageAction API.
6 6
7 var binding = require('binding').Binding.create('pageAction'); 7 var binding = require('binding').Binding.create('pageAction');
8 8
9 var setIcon = require('setIcon').setIcon; 9 var setIcon = require('setIcon').setIcon;
10 var sendRequest = require('sendRequest').sendRequest;
10 11
11 binding.registerCustomHook(function(bindingsAPI) { 12 binding.registerCustomHook(function(bindingsAPI) {
12 var apiFunctions = bindingsAPI.apiFunctions; 13 var apiFunctions = bindingsAPI.apiFunctions;
13 14
14 apiFunctions.setHandleRequest('setIcon', function(details, callback) { 15 apiFunctions.setHandleRequest('setIcon', function(details, callback) {
15 setIcon(details, callback, this.name, this.definition.parameters, 16 setIcon(details, function(args) {
16 'page action'); 17 sendRequest(this.name, [args, callback], this.definition.parameters);
18 }.bind(this));
17 }); 19 });
18 }); 20 });
19 21
20 exports.binding = binding.generate(); 22 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698