Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 477173003: Check if user provided more than one option for pdfium_test. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Check if user provided more than one option for pdfium_test. R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/8f2c3dc

Patch Set 1 #

Patch Set 2 : Tue 08/19/2014 14:38:22.91 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M samples/pdfium_test.cc View 1 2 chunks +10 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-19 21:40:01 UTC) #1
Bo Xu
On 2014/08/19 21:40:01, Vitaly Buka wrote: I guess we don't want to support, say, output ...
6 years, 4 months ago (2014-08-20 05:23:23 UTC) #2
Bo Xu
https://codereview.chromium.org/477173003/diff/20001/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/477173003/diff/20001/samples/pdfium_test.cc#newcode331 samples/pdfium_test.cc:331: WriteEmf(page, name, i); When do WriteEmf, bitmap is created ...
6 years, 4 months ago (2014-08-20 05:25:59 UTC) #3
Vitaly Buka (NO REVIEWS)
On 2014/08/20 05:23:23, Bo Xu wrote: > On 2014/08/19 21:40:01, Vitaly Buka wrote: > > ...
6 years, 4 months ago (2014-08-20 08:28:01 UTC) #4
Bo Xu
On 2014/08/20 08:28:01, Vitaly Buka wrote: > On 2014/08/20 05:23:23, Bo Xu wrote: > > ...
6 years, 4 months ago (2014-08-20 17:00:26 UTC) #5
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 17:32:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as 8f2c3dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698