Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 477143002: Remove unnecessary updateGraphicsContext calls. (Closed)

Created:
6 years, 4 months ago by jbroman
Modified:
6 years, 4 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Remove unnecessary updateGraphicsContext calls. These don't do anything, since all it does is update the fill color, which is not even used in drawHighlightForText (it takes its own color argument). After this, nearly all updateGraphicsContext calls correspond to a paintTextWithShadows call, which opens some refactoring options. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/rendering/InlineTextBox.cpp View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbroman
This makes it easier to change from doing: updateGraphicsContext(...) paintText(...) context->clearDrawLooper() to having one method ...
6 years, 4 months ago (2014-08-15 14:23:34 UTC) #1
f(malita)
lgtm!
6 years, 4 months ago (2014-08-15 14:32:01 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-15 14:36:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/477143002/1
6 years, 4 months ago (2014-08-15 14:38:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 15:31:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 16:11:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22960)
6 years, 4 months ago (2014-08-15 16:11:43 UTC) #7
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-15 16:46:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/477143002/1
6 years, 4 months ago (2014-08-15 16:46:30 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:20:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 180376

Powered by Google App Engine
This is Rietveld 408576698