Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 47713002: AllocationsTracker: introduce heap-profiler-always-track-allocations flag (Closed)

Created:
7 years, 1 month ago by loislo
Modified:
7 years, 1 month ago
Reviewers:
yurys
CC:
v8-dev, yurys, alph
Visibility:
Public.

Description

AllocationsTracker: introduce heap-profiler-always-track-allocations flag It gives us a chance to track allocations from start. Also it gives us ability to create snapshot.cc with enabled allocation tracking. BUG=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
loislo
I built v8 snapshot and ran TrackHeapAllocations with the flag and got crash. # # ...
7 years, 1 month ago (2013-10-27 19:33:56 UTC) #1
yurys
7 years, 1 month ago (2013-10-28 08:17:24 UTC) #2
https://codereview.chromium.org/47713002/diff/1/src/heap-profiler.h
File src/heap-profiler.h (right):

https://codereview.chromium.org/47713002/diff/1/src/heap-profiler.h#newcode88
src/heap-profiler.h:88: FLAG_heap_profiler_always_track_allocations;
Should we also call HeapProfiler::StartHeapObjectsTracking on start if the flag
is true?

Powered by Google App Engine
This is Rietveld 408576698