Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 477113002: DevTools: [SSP] fix "insert style rule" button on mac (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] fix "insert style rule" button on mac This patch moves insert style rule button further to the left to not overlap with scrollbar. It also fixes its width. As a drive-by, this patch sets "translateZ" rule hack on styles sidebar pane as a workaround for compositor bug. This makes scrollbar appear on MB Air. BUG=404102 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180359

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/devtools/front_end/elementsPanel.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-15 11:00:05 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-15 11:49:49 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 11:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/477113002/20001
6 years, 4 months ago (2014-08-15 11:51:10 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 12:48:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180359

Powered by Google App Engine
This is Rietveld 408576698