Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 477103004: Send empty video frames when screen is not changing. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 4 months ago
Reviewers:
Jamie, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Send empty video frames when screen is not changing. Before r272790 the host was sending empty packets 30 times a second when nothing is changing on the screen. After that change and r281677 the frequency was decreased to 5 frame per second. It looks like those changes degraded performance for some users. This change partially restores previous behavior. Empty packets are send for each captured frame even when nothing is changing on the screen. Keep-alive packets are sent every 200ms when there are no other video packets, e.g. when the video stream is paused. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M remoting/host/video_scheduler.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-15 19:08:26 UTC) #1
Jamie
lgtm
6 years, 4 months ago (2014-08-15 19:14:52 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-15 19:16:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/477103004/1
6 years, 4 months ago (2014-08-15 19:18:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 22:23:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290028

Powered by Google App Engine
This is Rietveld 408576698