Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5997)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Issue 477103003: browser test for profile chooser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-enable ProfileChooserViewBrowserTest Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
index 19dc37c95b230aaad950151eb1fd8ecf58e75498..bc6b026de864d2cb20a3ca182e319448a495f966 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
@@ -83,9 +83,9 @@ void ProfileChooserViewBrowserTest::OpenProfileChooserView() {
#define MAYBE_ViewProfileUMA ViewProfileUMA
#endif
-// TODO(mlerman): Re-enable the test to MAYBE_ViewProfileUMA once there is a
-// launch plan for EnableAccountConsistency.
-IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, DISABLED_ViewProfileUMA) {
+IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, MAYBE_ViewProfileUMA) {
+ base::HistogramTester histograms;
+ // If multiprofile mode is not enabled, you can't switch between profiles.
if (!profiles::IsMultipleProfilesEnabled())
return;
@@ -93,4 +93,7 @@ IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, DISABLED_ViewProfileUMA) {
profile->GetPrefs()->SetInteger(prefs::kProfileAvatarTutorialShown, 0);
ASSERT_NO_FATAL_FAILURE(OpenProfileChooserView());
+
+ histograms.ExpectUniqueSample("Profile.NewAvatarMenu.Upgrade",
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW, 1);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698