Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 477103003: browser test for profile chooser (Closed)

Created:
6 years, 4 months ago by Mike Lerman
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Re-enable the browser test for the ProfileChooserView. BUG=357693 Committed: https://crrev.com/b62717e4f695eea600af22f7916c965f43549d5d Cr-Commit-Position: refs/heads/master@{#291747}

Patch Set 1 : Re-enable ProfileChooserViewBrowserTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mike Lerman
Hey Mike, Just re-enabling a browser test. Review when you have a chance, please. Thanks, ...
6 years, 4 months ago (2014-08-22 16:39:54 UTC) #1
msw
lgtm
6 years, 4 months ago (2014-08-22 18:07:28 UTC) #2
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-22 18:08:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/477103003/20001
6 years, 4 months ago (2014-08-22 18:10:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:16:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:24:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8674)
6 years, 4 months ago (2014-08-22 19:24:51 UTC) #7
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-25 20:04:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/477103003/20001
6 years, 4 months ago (2014-08-25 20:05:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (20001) as da794f9dc2146f43233471859d2c57a65da8cde0
6 years, 4 months ago (2014-08-25 20:09:05 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b62717e4f695eea600af22f7916c965f43549d5d
Cr-Commit-Position: refs/heads/master@{#291747}

Powered by Google App Engine
This is Rietveld 408576698