Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 477053002: Add a QuicSustainedBandwidthEstimator class. Not yet used. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@re-add_DCHECK_to_ensure_packets_73128051
Project:
chromium
Visibility:
Public.

Description

Add a QuicSustainedBandwidthEstimator class. Not yet used. Followup CL (internal change: 72831442) in progress (not ready for review, but in case you want to see intended usage) which does the following: 1) Use this in the QuicSentPacketManager. 2) Detect substantial differences between subsequent sustained bandwidth estimates. 3) Send estimates to client in server config update. Merge internal change: 73132177 R=rch@chromium.org

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -0 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A net/quic/quic_sustained_bandwidth_recorder.h View 1 chunk +76 lines, -0 lines 3 comments Download
A net/quic/quic_sustained_bandwidth_recorder.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A net/quic/quic_sustained_bandwidth_recorder_test.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-15 02:34:16 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_bandwidth_recorder.h File net/quic/quic_sustained_bandwidth_recorder.h (right): https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_bandwidth_recorder.h#newcode46 net/quic/quic_sustained_bandwidth_recorder.h:46: int32 MaxBandwidthTimestamp() const { rjshade@: should we use int64 ...
6 years, 4 months ago (2014-08-15 02:35:35 UTC) #2
Robbie Shade
https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_bandwidth_recorder.h File net/quic/quic_sustained_bandwidth_recorder.h (right): https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_bandwidth_recorder.h#newcode46 net/quic/quic_sustained_bandwidth_recorder.h:46: int32 MaxBandwidthTimestamp() const { On 2014/08/15 02:35:35, ramant wrote: ...
6 years, 4 months ago (2014-08-15 12:08:38 UTC) #3
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-15 14:38:48 UTC) #4
ramant (doing other things)
6 years, 4 months ago (2014-08-15 17:54:18 UTC) #5
https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_band...
File net/quic/quic_sustained_bandwidth_recorder.h (right):

https://codereview.chromium.org/477053002/diff/1/net/quic/quic_sustained_band...
net/quic/quic_sustained_bandwidth_recorder.h:46: int32 MaxBandwidthTimestamp()
const {
On 2014/08/15 12:08:38, Robbie Shade wrote:
> On 2014/08/15 02:35:35, ramant wrote:
> > rjshade@: should we use int64 instead of int32?
> 
> Yep, thanks!

Great. Will submit the change to the internal source tree first.

thanks
raman

Powered by Google App Engine
This is Rietveld 408576698