Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 47703005: Fix DelegatedFrameResourceCollection thread safety (Closed)

Created:
7 years, 1 month ago by piman
Modified:
7 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix DelegatedFrameResourceCollection thread safety Don't keep a ref to DelegatedFrameResourceCollection inside the return resources callback, because it is called from a thread. BUG=None R=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -15 lines) Patch
M cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/delegated_frame_resource_collection.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/layers/delegated_frame_resource_collection.cc View 2 chunks +12 lines, -11 lines 0 comments Download
A cc/layers/delegated_frame_resource_collection_unittest.cc View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
7 years, 1 month ago (2013-10-30 04:42:12 UTC) #1
danakj
LGTM weakptr didnt work in the DRLayer, but it does work in the collection since ...
7 years, 1 month ago (2013-10-30 16:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/47703005/1
7 years, 1 month ago (2013-10-30 16:29:59 UTC) #3
piman
On 2013/10/30 16:28:46, danakj wrote: > LGTM > > weakptr didnt work in the DRLayer, ...
7 years, 1 month ago (2013-10-30 16:31:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=215812
7 years, 1 month ago (2013-10-30 19:15:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/47703005/1
7 years, 1 month ago (2013-10-30 19:19:10 UTC) #6
piman
7 years, 1 month ago (2013-10-30 20:35:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r231915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698