Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/v8natives.js

Issue 47703003: Make Object.freeze/seal/preventExtensions observable (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: cr comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1231 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 return obj; 1242 return obj;
1243 } 1243 }
1244 1244
1245 1245
1246 // ES5 section 15.2.3.9. 1246 // ES5 section 15.2.3.9.
1247 function ObjectFreeze(obj) { 1247 function ObjectFreeze(obj) {
1248 if (!IS_SPEC_OBJECT(obj)) { 1248 if (!IS_SPEC_OBJECT(obj)) {
1249 throw MakeTypeError("called_on_non_object", ["Object.freeze"]); 1249 throw MakeTypeError("called_on_non_object", ["Object.freeze"]);
1250 } 1250 }
1251 var isProxy = %IsJSProxy(obj); 1251 var isProxy = %IsJSProxy(obj);
1252 if (isProxy || %HasNonStrictArgumentsElements(obj)) { 1252 if (isProxy || %HasNonStrictArgumentsElements(obj) || %IsObserved(obj)) {
1253 if (isProxy) { 1253 if (isProxy) {
1254 ProxyFix(obj); 1254 ProxyFix(obj);
1255 } 1255 }
1256 var names = ObjectGetOwnPropertyNames(obj); 1256 var names = ObjectGetOwnPropertyNames(obj);
1257 for (var i = 0; i < names.length; i++) { 1257 for (var i = 0; i < names.length; i++) {
1258 var name = names[i]; 1258 var name = names[i];
1259 var desc = GetOwnProperty(obj, name); 1259 var desc = GetOwnProperty(obj, name);
1260 if (desc.isWritable() || desc.isConfigurable()) { 1260 if (desc.isWritable() || desc.isConfigurable()) {
1261 if (IsDataDescriptor(desc)) desc.setWritable(false); 1261 if (IsDataDescriptor(desc)) desc.setWritable(false);
1262 desc.setConfigurable(false); 1262 desc.setConfigurable(false);
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
1830 %SetCode($Function, FunctionConstructor); 1830 %SetCode($Function, FunctionConstructor);
1831 %SetProperty($Function.prototype, "constructor", $Function, DONT_ENUM); 1831 %SetProperty($Function.prototype, "constructor", $Function, DONT_ENUM);
1832 1832
1833 InstallFunctions($Function.prototype, DONT_ENUM, $Array( 1833 InstallFunctions($Function.prototype, DONT_ENUM, $Array(
1834 "bind", FunctionBind, 1834 "bind", FunctionBind,
1835 "toString", FunctionToString 1835 "toString", FunctionToString
1836 )); 1836 ));
1837 } 1837 }
1838 1838
1839 SetUpFunction(); 1839 SetUpFunction();
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698