[Profiles] Fix the usage of custom/default names and avatars

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 1119 matching lines @@
 // browser on first run.
 const char kImportSearchEngine[] = "import_search_engine";
 
 // Boolean that specifies whether to import the saved passwords from the default
 // browser on first run.
 const char kImportSavedPasswords[] = "import_saved_passwords";
 
 // Profile avatar and name
 const char kProfileAvatarIndex[] = "profile.avatar_index";
 const char kProfileName[] = "profile.name";
+// Whether a profile is using a default avatar name (eg. Pickles or Person 1).
+// A value of -1 means the profile is using a default name without having
+// explicitely chosen it (i.e. it was assigned by default at profile creation),
+// 1 means that the profile is using a default name having chosen it (i.e. the

[Bernhard Bauer, 2014/08/15 14:39:22]

Can you define an enum for these values?

[noms (inactive), 2014/08/15 16:22:47]

Changed it to a bool.
On 2014/08/15 14:39:22, Bernhard Bauer wrote:

+// user specifically chose Pickles) and 0 means that the profile has a custom
+// name (i.e. Batman).
+const char kProfileUsingDefaultName[] = "profile.using_default_name";
+// Whether a profile is using an avatar without having explicitely chosen it
+// (i.e. was assigned by default by legacy profile creation).
+const char kProfileUsingDefaultAvatar[] = "profile.using_default_avatar";
+const char kProfileUsingGAIAAvatar[] = "profile.using_gaia_avatar";
 
 // The supervised user ID.
 const char kSupervisedUserId[] = "profile.managed_user_id";
 
 // 64-bit integer serialization of the base::Time when the user's GAIA info
 // was last updated.
 const char kProfileGAIAInfoUpdateTime[] = "profile.gaia_info_update_time";
 
 // The URL from which the GAIA profile picture was downloaded. This is cached to
 // prevent the same picture from being downloaded multiple times.
@@ skipping 1183 matching lines @@
 const char kPartnerBookmarkMappings[] = "partnerbookmarks.mappings";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 
 // Whether Guest Mode is enabled within the browser.
 const char kBrowserGuestModeEnabled[] = "profile.browser_guest_enabled";
 
 }  // namespace prefs