Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 476953002: User metrics for distilled pages (Closed)

Created:
6 years, 4 months ago by smaslo
Modified:
6 years, 4 months ago
Reviewers:
Yaron, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

User metrics for distilled pages Metrics to track how many times users open a distilled page or distilled page preferences. BUG=383630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289965

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added yfriedman as owner for new actions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
smaslo
6 years, 4 months ago (2014-08-14 20:34:31 UTC) #1
Yaron
lgtm https://codereview.chromium.org/476953002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/476953002/diff/1/tools/metrics/actions/actions.xml#newcode2464 tools/metrics/actions/actions.xml:2464: <owner>smaslo@chromium.org</owner> please add me as well since it'll ...
6 years, 4 months ago (2014-08-14 22:59:12 UTC) #2
Yaron
I'm not an owner though
6 years, 4 months ago (2014-08-14 22:59:24 UTC) #3
smaslo
https://codereview.chromium.org/476953002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/476953002/diff/1/tools/metrics/actions/actions.xml#newcode2464 tools/metrics/actions/actions.xml:2464: <owner>smaslo@chromium.org</owner> On 2014/08/14 22:59:12, Yaron wrote: > please add ...
6 years, 4 months ago (2014-08-14 23:02:58 UTC) #4
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-14 23:41:22 UTC) #5
smaslo
The CQ bit was unchecked by smaslo@chromium.org
6 years, 4 months ago (2014-08-14 23:41:30 UTC) #6
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-15 15:14:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smaslo@chromium.org/476953002/20001
6 years, 4 months ago (2014-08-15 15:16:03 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 16:38:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 16:45:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/4596)
6 years, 4 months ago (2014-08-15 16:45:05 UTC) #11
Ilya Sherman
LGTM
6 years, 4 months ago (2014-08-15 18:44:44 UTC) #12
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-15 18:45:59 UTC) #13
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-15 18:46:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smaslo@chromium.org/476953002/20001
6 years, 4 months ago (2014-08-15 18:48:44 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 19:06:50 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289965

Powered by Google App Engine
This is Rietveld 408576698