Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: Tools/GardeningServer/ui/test/ct-failure-stream-tests.html

Issue 476903004: [sheriff-o-matic]: Basic trooper display for sheriff-o-matic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-failure-stream-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-failure-stream-tests.html b/Tools/GardeningServer/ui/test/ct-failure-stream-tests.html
index 8a0b21453dcb75034b84c7c6f5a926f6b03d2db8..67773abac4709ae380c7589a3cdf49de19f2f659 100644
--- a/Tools/GardeningServer/ui/test/ct-failure-stream-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-failure-stream-tests.html
@@ -26,7 +26,8 @@ describe('ct-failure-stream', function() {
// ct-failure-stream will give these values to ct-commit-data,
// which will hit the network unless we figure out how to mock
// out ct-commit-data in a better way.
- stream.groups = [new CTFailureGroup([], undefined), new CTFailureGroup([], undefined)];
+ stream.groups = [new CTFailureGroup(new CTSheriffFailureGroupData([], undefined)),
+ new CTFailureGroup(new CTSheriffFailureGroupData([], undefined))];
stream.category = 'default';
setTimeout(function() {
var cards = stream.shadowRoot.querySelectorAll('ct-failure-card');
@@ -39,8 +40,8 @@ describe('ct-failure-stream', function() {
describe('category', function() {
it('should only show failure groups for the specified category', function(done) {
var failures = [new CTFailure('step', 'reason', [{key: 'a', annotation: {snoozeTime: Date.now() + 1000 * 1000}}])];
- var snoozed = new CTFailureGroup(failures, undefined);
- stream.groups = [new CTFailureGroup([], undefined), snoozed];
+ var snoozed = new CTFailureGroup(new CTSheriffFailureGroupData(failures, undefined));
+ stream.groups = [new CTFailureGroup(new CTSheriffFailureGroupData([], undefined)), snoozed];
ojan 2014/09/04 02:58:44 No need to pass undefined for arguments you're lea
ojan 2014/09/04 02:58:44 I know the old code was doing this...but, no need
shans 2014/09/05 00:08:20 Done.
shans 2014/09/05 00:08:20 Acknowledged.
stream.category = 'snoozed';
setTimeout(function() {
var cards = stream.shadowRoot.querySelectorAll('ct-failure-card');

Powered by Google App Engine
This is Rietveld 408576698