Tools/GardeningServer/sheriff-o-matic.html - Issue 476903004: [sheriff-o-matic]: Basic trooper display for sheriff-o-matic.

Side by Side Diff: Tools/GardeningServer/sheriff-o-matic.html

Issue 476903004: [sheriff-o-matic]: Basic trooper display for sheriff-o-matic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Tools/GardeningServer/model/ct-failures.html ('K') | « Tools/GardeningServer/model/test/ct-failures-tests.html ('k') | Tools/GardeningServer/test/run-unit-tests.html » ('j') | Tools/GardeningServer/ui/ct-failure-card.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2014 The Chromium Authors. All rights reserved.	2 Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5	5

6 The favicons are from the awesome famfamfam.com, which is the website of Mark	6 The favicons are from the awesome famfamfam.com, which is the website of Mark

7 James, a web developer from Birmingham, UK.	7 James, a web developer from Birmingham, UK.

8 -->	8 -->

9 <!DOCTYPE html>	9 <!DOCTYPE html>

10 <head>	10 <head>

11 <title>Sheriff-O-Matic</title>	11 <title>Sheriff-O-Matic</title>

12 <meta charset="utf-8">	12 <meta charset="utf-8">

13 <meta name="viewport" content="width=device-width, user-scalable=no">	13 <meta name="viewport" content="width=device-width, user-scalable=no">

14 <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Open+Sans:40 0,700">	14 <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Open+Sans:40 0,700">

15 <style>	15 <style>

16 html, body {	16 html, body {

17 height: 100%;	17 height: 100%;

18 }	18 }

19 body {	19 body {

20 font-family: 'Open Sans';	20 font-family: 'Open Sans';

21 font-size: 14px;	21 font-size: 14px;

22 margin: 0px;	22 margin: 0px;

23 }	23 }

24 </style>	24 </style>

	25 <script src='//www.google.com/jsapi'></script>
	ojan 2014/09/04 02:58:43 I'd rather we not include script tags at all. We u I'd rather we not include script tags at all. We use html imports everywhere so that the component that actually draws the chart imports it and we can use include-what-you-use style importing. Also, if we're going to include a charting library, I'd rather we include something more modern and maintained like http://www.chartjs.org/. But, I don't want to block you landing this patch on that...so, if you don't want to do that, can you make a ct-chart component and use that? Then the ct-chart component can have a FIXME to move to chartjs and nothing outside the component would know about this library. I just don't want us building a whole set of other charts and stuff on this library, so hopefully a FIXME will be enough to dissuade people. shans 2014/09/05 00:08:19 I actually tried that initially, but it seems that Show quoted text On 2014/09/04 02:58:43, ojan-only-code-yellow-reviews wrote: > I'd rather we not include script tags at all. We use html imports everywhere so > that the component that actually draws the chart imports it and we can use > include-what-you-use style importing. I actually tried that initially, but it seems that the google loading mechanism doesn't play very nicely with HTML Imports and Polymer elements. Show quoted text > Also, if we're going to include a charting library, I'd rather we include > something more modern and maintained like http://www.chartjs.org/. But, I don't > want to block you landing this patch on that...so, if you don't want to do that, > can you make a ct-chart component and use that? Then the ct-chart component can > have a FIXME to move to chartjs and nothing outside the component would know > about this library. I just don't want us building a whole set of other charts > and stuff on this library, so hopefully a FIXME will be enough to dissuade > people. OK, switched to chartjsnew (which is chartjs enhanced with some of the extra features that google charts provides).
	26 <script>

	27 google.load("visualization", "1", {packages: ["corechart"]});

	28 </script>

25 <script src="bower_components/platform/platform.js"></script>	29 <script src="bower_components/platform/platform.js"></script>

26 <link rel="import" href="bower_components/polymer/polymer.html">	30 <link rel="import" href="bower_components/polymer/polymer.html">

27 <link rel="import" href="ui/ct-sheriff-o-matic.html">	31 <link rel="import" href="ui/ct-sheriff-o-matic.html">

28 <ct-sheriff-o-matic></ct-sheriff-o-matic>	32 <ct-sheriff-o-matic></ct-sheriff-o-matic>

29 </head>	33 </head>

OLD	NEW