[sheriff-o-matic]: Basic trooper display for sheriff-o-matic.

Tools/GardeningServer/model/ct-failures.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../lib/net.html">
 <link rel="import" href="ct-builder-revisions.html">
 <link rel="import" href="ct-failure.html">
 <link rel="import" href="ct-failure-group.html">
+<link rel="import" href="ct-sheriff-failure-group-data.html">
+<link rel="import" href="ct-trooper-failure-group-data.html">
 <link rel="import" href="ct-commit-list.html">
 
 <script>
 function CTFailures(commitLog) {
   this.commitLog = commitLog;
   this.builderLatestRevisions = null;
-  this.failures = null;
+  this.failures = {}
   this.lastUpdateDate = null;
 
   // FIXME: Get this from
   // https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/gatekeeper_trees.json?format=text.
   this._trees = {
     blink: [
       "https://build.chromium.org/p/chromium.webkit",
     ],
     chromium: [
       "https://build.chromium.org/p/chromium",
       "https://build.chromium.org/p/chromium.chrome",
       "https://build.chromium.org/p/chromium.chromiumos",
       "https://build.chromium.org/p/chromium.gpu",
       "https://build.chromium.org/p/chromium.linux",
       "https://build.chromium.org/p/chromium.mac",
       "https://build.chromium.org/p/chromium.memory",
       "https://build.chromium.org/p/chromium.win"
     ],
   };
 }
 
+// FIXME: This could potentially move onto CTSheriffFailureGroupData as it isn't relevant to
+// trooper failures.
 // Reverse sorting order, if a > b, return a negative number.
 CTFailures.prototype._failureByTreeListComparator = function(tree, a, b) {
   if (tree === undefined)
     tree = 'chromium';
 
-  var rev_a = a.commitList.revisions;
-  var rev_b = b.commitList.revisions;
+  var rev_a = a.data.commitList.revisions;
+  var rev_b = b.data.commitList.revisions;
 
   if (!rev_a || !Object.keys(rev_a).length) {
     if (!rev_b || !Object.keys(rev_b).length)
       return 0;
     return 1;
   } else if (!rev_b || !Object.keys(rev_b).length) {
     return -1;
   }
 
   // Prioritize the tree's revision, if they are unequal (else, fallback below)
@@ skipping 14 matching lines @@
       return -1;
 
     if (a_list.last() != b_list.last())
       return b_list.last() - a_list.last();
   }
   return 0;
 };
 
 CTFailures.prototype.update = function() {
   var annotationPromise = CTFailureGroup.fetchAnnotations();
-  net.json('http://sheriff-o-matic.appspot.com/alerts').then(function(data) {
-    annotationPromise.then(function(annotations) {
-      // FIXME: Don't special-case the blink master.
-      this.builderLatestRevisions = new CTBuilderRevisions(data.latest_builder_info['chromium.webkit']);
-      this.failures = {};
-      this.lastUpdateDate = new Date(data.date * 1000);
-      // Update |failures| with the appropriate CTFailureGroup's for each
-      // tree.
-      data.range_groups.forEach(function(rangeGroup) {
-        this._processFailuresForRangeGroup(rangeGroup, data.alerts, annotations);
-      }.bind(this));
-      // Sort failure groups so that newer failures are shown at the top
-      // of the UI.
-      Object.keys(this.failures, function (tree, failuresByTree) {
-        this.failures[tree].sort(this._failureByTreeListComparator.bind(this, tree));
-      }.bind(this));
+  Promise.all([annotationPromise, net.json('http://sheriff-o-matic.appspot.com/alerts'),
+      net.json('http://trooper-o-matic.appspot.com/alerts')]).then(function(data_array) {
+    var annotations = data_array[0];
+    var sheriff_data = data_array[1];
+    var trooper_data = data_array[2];
+
+    // FIXME: Don't special-case the blink master.
+    this.builderLatestRevisions = new CTBuilderRevisions(sheriff_data.latest_builder_info['chromium.webkit']);
+    this.lastUpdateDate = new Date(sheriff_data.date * 1000);
+    // Update |failures| with the appropriate CTFailureGroup's for each
+    // tree.
+    sheriff_data.range_groups.forEach(function(rangeGroup) {
+      this._processFailuresForRangeGroup(rangeGroup, sheriff_data.alerts, annotations);
     }.bind(this));
+    // Sort failure groups so that newer failures are shown at the top
+    // of the UI.
+    Object.keys(this.failures, function (tree, failuresByTree) {
+      this.failures[tree].sort(this._failureByTreeListComparator.bind(this, tree));
+    }.bind(this));
+    this._processTrooperFailures(trooper_data);
   }.bind(this));
 };
 
 CTFailures.prototype._failureComparator = function(a, b) {
   if (a.step > b.step)
     return 1;
   if (a.step < b.step)
     return -1
   if (a.testName > b.testName)
     return 1;
   if (a.testName < b.testName)
     return -1
   return 0;
 };
 
+
+CTFailures.prototype._processTrooperFailures = function(data) {
+  var trooper_failures = [];
+  Object.keys(data, function(failureType, failuresByTree) {
+    Object.keys(failuresByTree, function(tree, failure) {
+      if (failure.should_alert)

[ojan, 2014/09/04 02:58:43]

Put curlies.

[shans, 2014/09/05 00:08:19]

Done.

+        trooper_failures.push(new CTFailureGroup(
+            new CTTrooperFailureGroupData(failure.details, failure.url, failure, failureType, tree)));
+    });
+  });
+  this.failures['trooper'] = trooper_failures;
+};
+
 CTFailures.prototype._processFailuresForRangeGroup = function(rangeGroup, alerts, annotations) {
   var masterToTree = {};
   Object.keys(this._trees, function(tree, masters) {
     masters.forEach(function(master) {
       masterToTree[master] = tree;
     });
   });
 
   // A rangeGroup may be related to multiple alerts (via |failure_keys|). Categorize
   // these failures by reason (cause of failure), so that they can be grouped in the UI
@@ skipping 54 matching lines @@
           new CTFailure(failure.step, failure.reason, resultsByBuilder));
     })
   });
 
   Object.keys(groupedFailures, function(tree, failures) {
     failures.sort(this._failureComparator);
 
     if (!this.failures[tree])
       this.failures[tree] = [];
     var commitList = new CTCommitList(this.commitLog, rangeGroup.likely_revisions);
-    this.failures[tree].push(new CTFailureGroup(failures, commitList));
+    this.failures[tree].push(new CTFailureGroup(new CTSheriffFailureGroupData(failures, commitList)));
   }.bind(this));
 };
 
 </script>