Add a "Link Bug" button to associate a bug with a failure

Add a "Link Bug" button to associate a bug with a failure

R=ojan@chromium.org
NOTRY=true
BUG=399734
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180401

[cbiesinger, 2014-08-15 04:30:00]

Future enhancements:
- Unlink bug
- Link multiple bugs
- File bug directly from sheriff-o-matic

[ojan, 2014-08-15 04:53:40]

lgtm

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
File Tools/GardeningServer/model/ct-failure-group.html (right):

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure-group.html:29: bugNumber: bug,
Can we s/bugNumber/bug and have the value actually be a URL? That way we can
link to v8/skia/etc bugs as well. We still allow you to just input a number and
we prepend the crbug.com for you before we store the value.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure-group.html:35: this.hasBug =
this.annotation.bugNumber !== undefined;
Lets just set this.bug. 

Also, we should make annotation private (i.e., this._annotation).

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-failure-card.html (right):

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:68: <div id="builder-column">
This is leftover from a previous iteration of the code, yes? No longer needed?

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:95: <paper-input label="Bug#"
type="number" floatingLabel min="10000" id="bugNumber"></paper-input>
Why have a min?

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:96: <paper-button label="OK"
on-tap="{{ saveBug }}" affirmative autofocus id="dialogOK"></paper-button>
Nit: I prefer the dialogOk style to avoid abominations like XMLHttpRequest.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:96: <paper-button label="OK"
on-tap="{{ saveBug }}" affirmative autofocus id="dialogOK"></paper-button>
Nit: I prefer the dialogOk style to avoid abominations like XMLHttpRequest.

[cbiesinger, 2014-08-16 00:46:16]

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
File Tools/GardeningServer/model/ct-failure-group.html (right):

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure-group.html:29: bugNumber: bug,
On 2014/08/15 04:53:39, ojan-only-code-yellow-reviews wrote:
> Can we s/bugNumber/bug and have the value actually be a URL? That way we can
> link to v8/skia/etc bugs as well. We still allow you to just input a number
and
> we prepend the http://crbug.com for you before we store the value.

Done.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure-group.html:35: this.hasBug =
this.annotation.bugNumber !== undefined;
On 2014/08/15 04:53:39, ojan-only-code-yellow-reviews wrote:
> Lets just set this.bug. 
> 
> Also, we should make annotation private (i.e., this._annotation).

Done.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-failure-card.html (right):

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:68: <div id="builder-column">
On 2014/08/15 04:53:39, ojan-only-code-yellow-reviews wrote:
> This is leftover from a previous iteration of the code, yes? No longer needed?

Yes, changed back.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:95: <paper-input label="Bug#"
type="number" floatingLabel min="10000" id="bugNumber"></paper-input>
On 2014/08/15 04:53:39, ojan-only-code-yellow-reviews wrote:
> Why have a min?

To make sure that people use stuff that looks like a bug number, but per your
other comment, I'll make this use a string anyway so that URLs work.

https://codereview.chromium.org/476903003/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-failure-card.html:96: <paper-button label="OK"
on-tap="{{ saveBug }}" affirmative autofocus id="dialogOK"></paper-button>
On 2014/08/15 04:53:40, ojan-only-code-yellow-reviews wrote:
> Nit: I prefer the dialogOk style to avoid abominations like XMLHttpRequest.

Done.

[cbiesinger, 2014-08-16 00:46:31]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2014-08-16 00:47:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/476903003/20001

[commit-bot: I haz the power, 2014-08-16 00:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 00:47:44]

Failed to apply patch for Tools/GardeningServer/model/ct-failure-group.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/GardeningServer/model/ct-failure-group.html
  Hunk #1 succeeded at 10 (offset 2 lines).
  Hunk #2 FAILED at 24.
  Hunk #3 succeeded at 61 (offset 12 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Tools/GardeningServer/model/ct-failure-group.html.rej

Patch:       Tools/GardeningServer/model/ct-failure-group.html
Index: Tools/GardeningServer/model/ct-failure-group.html
diff --git a/Tools/GardeningServer/model/ct-failure-group.html
b/Tools/GardeningServer/model/ct-failure-group.html
index
84d01dc9177f9b3b34157482aece5da39e030ff7..617ffd585f8fa3d8eef7c93be7f6d85913c71603
100644
--- a/Tools/GardeningServer/model/ct-failure-group.html
+++ b/Tools/GardeningServer/model/ct-failure-group.html
@@ -8,7 +8,7 @@ found in the LICENSE file.
 function CTFailureGroup(key, failures, annotation) {
   this.key = key;
   this.failures = failures;
-  this.annotation = annotation || {};
+  this._annotation = annotation || {};
   this._computeProperties();
 }
 
@@ -24,8 +24,21 @@ CTFailureGroup.prototype.unsnooze = function() {
   });
 };
 
+CTFailureGroup.prototype.setBug = function(bug) {
+  if (/^[0-9]+$/.test(bug))
+    bug = 'http://crbug.com/' + bug;
+  return this._annotate({
+    bug: bug,
+  });
+};
+
 CTFailureGroup.prototype._computeProperties = function() {
-  this.isSnoozed = Date.now() < this.annotation.snoozeTime;
+  this.isSnoozed = Date.now() < this._annotation.snoozeTime;
+  this.bug = this._annotation.bug;
+  if (this.bug !== undefined)
+    this.bugLabel = 'Bug ' + /([0-9]{3,})/.exec(this.bug)[0];
+  else
+    this.bugLabel = undefined;
 };
 
 CTFailureGroup.prototype._annotate = function(newAnnotation) {
@@ -49,7 +62,7 @@ CTFailureGroup.prototype._annotate = function(newAnnotation) {
 
     localStorage.CTFailureGroupAnnotations = JSON.stringify(annotations);
 
-    this.annotation = annotation;
+    this._annotation = annotation;
     this._computeProperties();
   }.bind(this));
 };

[cbiesinger, 2014-08-16 01:42:47]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2014-08-16 01:43:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/476903003/40001

[commit-bot: I haz the power, 2014-08-16 01:44:11]

Committed patchset #3 (40001) as 180401