Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 476893002: DevTools: [SSP] fix Ctrl-Click navigation over selector (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] fix Ctrl-Click navigation over selector The codemirror got frozen because selection from its input text area was stolen via "add new property" editing functionality. BUG=402838 R=apavlov, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
PTAL
6 years, 4 months ago (2014-08-14 17:56:15 UTC) #1
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-15 08:21:37 UTC) #2
apavlov
lgtm
6 years, 4 months ago (2014-08-15 08:21:37 UTC) #3
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 08:21:59 UTC) #4
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 08:22:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/476893002/1
6 years, 4 months ago (2014-08-15 08:23:15 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 09:24:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180343

Powered by Google App Engine
This is Rietveld 408576698