Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4606)

Unified Diff: chrome/common/extensions/api/push_messaging.idl

Issue 476883003: Add deprecation message in chrome.pushMessaging API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Applying update setting deprecation to Chrome 38, removal to Chrome 40. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/push_messaging.idl
diff --git a/chrome/common/extensions/api/push_messaging.idl b/chrome/common/extensions/api/push_messaging.idl
index 0f6917542248db1a813fd7b91b7a668a333b924d..9012d5de12dfa843a708ba7fa08d0803a37169d0 100644
--- a/chrome/common/extensions/api/push_messaging.idl
+++ b/chrome/common/extensions/api/push_messaging.idl
@@ -2,9 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Use <code>chrome.pushMessaging</code> to enable apps and extensions to
-// receive message data sent through
+// The <code>chrome.pushMessaging</code> API is currently deprecated since
not at google - send to devlin 2014/08/21 00:36:33 No "currently".
fgorski 2014/08/22 18:23:38 Done.
+// Chrome 38, and will no longer be supported in Chrome 40.
+// Switch to <code>$(ref:gcm)</code> to take advantage of
// <a href="cloudMessaging.html">Google Cloud Messaging</a>.
+[deprecated="Use $(ref:gcm) API"]
namespace pushMessaging {
dictionary Message {
@@ -31,6 +33,7 @@ namespace pushMessaging {
// to trigger push messages back to the app or extension.
// If the interactive flag is set, we will ask the user to log in
// when they are not already logged in.
+ [deprecated="Use $(ref:gcm) API"]
not at google - send to devlin 2014/08/21 00:36:33 Nit: seems like it should read either "the gcm API
fgorski 2014/08/22 18:23:39 Done.
static void getChannelId(optional boolean interactive,
ChannelIdCallback callback);
};
@@ -38,6 +41,7 @@ namespace pushMessaging {
interface Events {
// Fired when a push message has been received.
// |message| : The details associated with the message.
+ [deprecated="Use $(ref:gcm)"]
static void onMessage(Message message);
};
};

Powered by Google App Engine
This is Rietveld 408576698