Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 476883003: Add deprecation message in chrome.pushMessaging API (Closed)

Created:
6 years, 4 months ago by fgorski
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou, ahernandez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add deprecation message in chrome.pushMessaging API Deprecation messages are added in: * getChannelId function - displayed to console * documentation of chrome.pushMessaging/GCM for Chrome V1 BUG=403952 Committed: https://crrev.com/0dcab3d52efddd480376816797a8257a371995b9 Cr-Commit-Position: refs/heads/master@{#293539}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Updates based on code review feedback #

Patch Set 3 : Applying update setting deprecation to Chrome 38, removal to Chrome 40. #

Total comments: 4

Patch Set 4 : Final updates to the documentation in idl #

Patch Set 5 : Updating the API removal milestone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/extensions/api/push_messaging.idl View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/cloudMessagingV1.html View 1 2 3 4 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/gcm_server.html View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 24 (7 generated)
fgorski
Ben, Mike, please take a look. I want both of you to confirm that wording ...
6 years, 4 months ago (2014-08-14 22:06:42 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right): https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc#newcode100 chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:100: WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_WARNING, kDeprecationMessage); How often do apps call this method? ...
6 years, 4 months ago (2014-08-14 22:16:08 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right): https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc#newcode101 chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:101: On 2014/08/14 22:16:08, kalman wrote: > Also: we should ...
6 years, 4 months ago (2014-08-15 01:40:13 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right): https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc#newcode101 chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:101: On 2014/08/15 01:40:13, Yoyo Zhou wrote: > On 2014/08/14 ...
6 years, 4 months ago (2014-08-15 15:54:17 UTC) #4
Yoyo Zhou
https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right): https://codereview.chromium.org/476883003/diff/1/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc#newcode101 chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:101: On 2014/08/15 15:54:17, kalman wrote: > On 2014/08/15 01:40:13, ...
6 years, 4 months ago (2014-08-15 19:25:32 UTC) #5
fgorski
Ben, I applied comments and looked into how to get the install time message done. ...
6 years, 4 months ago (2014-08-20 22:46:47 UTC) #6
not at google - send to devlin
What you have is fine, so lgtm if you want to submit, but if you're ...
6 years, 4 months ago (2014-08-21 00:36:33 UTC) #7
fgorski
I will not be adding the feature annotation in this CL, but I can look ...
6 years, 4 months ago (2014-08-22 18:23:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/476883003/80001
6 years, 3 months ago (2014-09-03 23:24:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1895)
6 years, 3 months ago (2014-09-04 02:25:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/476883003/80001
6 years, 3 months ago (2014-09-04 16:21:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/12964)
6 years, 3 months ago (2014-09-04 17:57:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/476883003/80001
6 years, 3 months ago (2014-09-04 23:34:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10364)
6 years, 3 months ago (2014-09-05 01:48:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/476883003/80001
6 years, 3 months ago (2014-09-05 16:13:57 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 8b7a0e188a0d57e6214c8c463bbe61da3fabb361
6 years, 3 months ago (2014-09-05 16:57:23 UTC) #23
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:11 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0dcab3d52efddd480376816797a8257a371995b9
Cr-Commit-Position: refs/heads/master@{#293539}

Powered by Google App Engine
This is Rietveld 408576698