chrome/browser/extensions/extension_toolbar_model.h - Issue 476873002: Make hiding an extension action cause it to go to the overflow menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.h

Issue 476873002: Make hiding an extension action cause it to go to the overflow menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model_unittest.cc ('k') | chrome/browser/extensions/extension_toolbar_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_toolbar_model.h

diff --git a/chrome/browser/extensions/extension_toolbar_model.h b/chrome/browser/extensions/extension_toolbar_model.h

index b495f5d6e12d77d24bd1b0cc46b3066c66df8c33..05b143d89985dada27060394a545658677fd5364 100644

--- a/chrome/browser/extensions/extension_toolbar_model.h

+++ b/chrome/browser/extensions/extension_toolbar_model.h

@@ -181,6 +181,13 @@ class ExtensionToolbarModel : public content::NotificationObserver,

// Save the model to prefs.

void UpdatePrefs();

+ // Updates |extension|'s browser action visibility pref if the browser action

+ // is in the overflow menu and should be considered hidden.

+ void MaybeUpdateVisibilityPref(const Extension* extension, int index);

+ // Calls MaybeUpdateVisibilityPref() for each extension in |toolbar_items|.

+ void MaybeUpdateVisibilityPrefs();

// Finds the last known visible position of the icon for an |extension|. The

// value returned is a zero-based index into the vector of visible items.

size_t FindNewPositionFromLastKnownGood(const Extension* extension);