Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 476823003: Fix Bluetooth Classic device polling issue. (Closed)

Created:
6 years, 4 months ago by rpaquay
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Bluetooth Classic device polling issue. With the recent device polling changes (https://codereview.chromium.org/424093004/), any failure in enumerating devices/services prevents the background polling task from reporting changes (to avoid reporting inconsistent configuration). However, when devices are offline and polling is done in "discovery" mode, enumerating services fails because the underlying SDP request fails. The workaround if to ask for cached services only instead, so that at least the services already previously known are returned and the polling operation can succeed. BUG=396337 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290061

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M device/bluetooth/bluetooth_task_manager_win.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 4 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rpaquay
6 years, 4 months ago (2014-08-14 16:52:22 UTC) #1
xiyuan
https://codereview.chromium.org/476823003/diff/1/device/bluetooth/bluetooth_task_manager_win.cc File device/bluetooth/bluetooth_task_manager_win.cc (right): https://codereview.chromium.org/476823003/diff/1/device/bluetooth/bluetooth_task_manager_win.cc#newcode573 device/bluetooth/bluetooth_task_manager_win.cc:573: goto TryAgain; Can we get rid of the "goto"?
6 years, 4 months ago (2014-08-14 19:35:29 UTC) #2
rpaquay
https://codereview.chromium.org/476823003/diff/1/device/bluetooth/bluetooth_task_manager_win.cc File device/bluetooth/bluetooth_task_manager_win.cc (right): https://codereview.chromium.org/476823003/diff/1/device/bluetooth/bluetooth_task_manager_win.cc#newcode573 device/bluetooth/bluetooth_task_manager_win.cc:573: goto TryAgain; On 2014/08/14 19:35:29, xiyuan wrote: > Can ...
6 years, 4 months ago (2014-08-15 19:55:33 UTC) #3
xiyuan
Awesome. LGTM!
6 years, 4 months ago (2014-08-15 20:04:25 UTC) #4
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 4 months ago (2014-08-15 20:31:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/476823003/20001
6 years, 4 months ago (2014-08-15 20:35:54 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 00:08:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290061

Powered by Google App Engine
This is Rietveld 408576698