Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 476803002: DevTools: [SSP] synchronize pseudoIds in styles sidebar pane with blink (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] synchronize pseudoIds in styles sidebar pane with blink This patch synchronizes diverged pseudoId names in Style Sidebar Pane with RenderStyleConstants.h. Ideally, they should be generated, but so far we don't have a solution for this. BUG=380644 R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
Ptal
6 years, 4 months ago (2014-08-14 15:45:25 UTC) #1
apavlov
lgtm
6 years, 4 months ago (2014-08-15 08:31:09 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 08:41:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/476803002/1
6 years, 4 months ago (2014-08-15 08:42:49 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 09:26:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180344

Powered by Google App Engine
This is Rietveld 408576698