Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: content/browser/renderer_host/input/gesture_text_selector.cc

Issue 476783002: Merge 285785 "Show handles even when dragging from outside selec..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2062/src/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/input/gesture_text_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/gesture_text_selector.cc
===================================================================
--- content/browser/renderer_host/input/gesture_text_selector.cc (revision 289590)
+++ content/browser/renderer_host/input/gesture_text_selector.cc (working copy)
@@ -40,15 +40,15 @@
}
case ui::ET_GESTURE_SCROLL_BEGIN: {
client_->Unselect();
- // TODO(changwan): check if we can show handles on ET_GESTURE_SCROLL_END
- // instead. Currently it is not possible as ShowSelectionHandles should
- // be called before we change the selection.
- client_->ShowSelectionHandlesAutomatically();
anchor_x_ = gesture.x;
anchor_y_ = gesture.y;
break;
}
case ui::ET_GESTURE_SCROLL_UPDATE: {
+ // TODO(changwan): check if we can show handles on ET_GESTURE_SCROLL_END
+ // instead. Currently it is not possible as ShowSelectionHandles should
+ // be called before we change the selection.
+ client_->ShowSelectionHandlesAutomatically();
client_->SelectRange(anchor_x_, anchor_y_, gesture.x, gesture.y);
break;
}
« no previous file with comments | « no previous file | content/browser/renderer_host/input/gesture_text_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698