Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 476773002: Nuke TimelineAllEventsReceived event (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -40 lines) Patch
M LayoutTests/inspector/console/console-timeline.html View 6 chunks +36 lines, -22 lines 0 comments Download
M LayoutTests/inspector/console/console-timeline-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 2 chunks +5 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
yurys
6 years, 4 months ago (2014-08-14 14:05:25 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-14 14:19:55 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-14 14:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/476773002/1
6 years, 4 months ago (2014-08-14 14:44:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 16:28:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 17:18:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22791)
6 years, 4 months ago (2014-08-14 17:18:33 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-15 07:32:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/476773002/1
6 years, 4 months ago (2014-08-15 07:33:10 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 08:43:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 09:24:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22911)
6 years, 4 months ago (2014-08-15 09:24:40 UTC) #12
yurys
6 years, 4 months ago (2014-08-15 10:47:54 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 manually as 180349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698