Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 476763004: Rename FullscreenElementStack to just Fullscreen (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
abarth-chromium, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, nessy, vcarbune.chromium, zoltan1
Project:
blink
Visibility:
Public.

Description

Rename FullscreenElementStack to just Fullscreen This class does more than just manage the fullscreen element stack, and the shorter name makes the code more readable in many places. In the renamed Fullscreen class, it also makes it more obvious when the actual fullscreen element stack is being manipulated. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180433

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -899 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentFullscreen.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ElementFullscreen.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
A + Source/core/dom/Fullscreen.h View 5 chunks +18 lines, -18 lines 0 comments Download
A + Source/core/dom/Fullscreen.cpp View 19 chunks +46 lines, -46 lines 0 comments Download
D Source/core/dom/FullscreenElementStack.h View 1 chunk +0 lines, -152 lines 0 comments Download
D Source/core/dom/FullscreenElementStack.cpp View 1 chunk +0 lines, -609 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/FullscreenController.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/web/WebDocument.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
PTAL. This will obviously conflict with my other changes, but if you like the rename ...
6 years, 4 months ago (2014-08-15 20:47:53 UTC) #1
philipj_slow
rebase
6 years, 4 months ago (2014-08-15 22:08:13 UTC) #2
philipj_slow
falken, on this and other fullscreen reviews, if it lgty but that's not enough to ...
6 years, 4 months ago (2014-08-16 21:08:05 UTC) #3
falken
On 2014/08/16 21:08:05, philipj wrote: > falken, on this and other fullscreen reviews, if it ...
6 years, 4 months ago (2014-08-18 02:17:23 UTC) #4
falken
lgtm abarth: can you review as Source/web OWNER trchen: FYI
6 years, 4 months ago (2014-08-18 03:15:25 UTC) #5
abarth-chromium
Source/web LGTM
6 years, 4 months ago (2014-08-18 04:26:54 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-18 07:18:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/476763004/20001
6 years, 4 months ago (2014-08-18 07:19:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (20001) as 180433
6 years, 4 months ago (2014-08-18 07:55:07 UTC) #9
philipj_slow
6 years, 4 months ago (2014-08-18 08:18:37 UTC) #10
Message was sent while issue was closed.
On 2014/08/18 02:17:23, falken wrote:
> On 2014/08/16 21:08:05, philipj wrote:
> > falken, on this and other fullscreen reviews, if it lgty but that's not
enough
> > to land, it would be great if you could also add tkent or whoever has the
> power
> > for what remains. (jochen is in my timezone but OOO for a while.)
> 
> Sure. Let me know if you'd like me to CQ something as well. In WebKit days
we'd
> say "cq?" to request CQ.

That sounds great, I'll request it where it makes sense going forward.

Powered by Google App Engine
This is Rietveld 408576698