OOP PDF - Add support for "page" open pdf parameter

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 <include src="../../../../ui/webui/resources/js/util.js">
 <include src="pdf_scripting_api.js">
 <include src="viewport.js">
 
@@ skipping 247 matching lines @@
    * Notify the plugin to print.
    */
   print_: function() {
     this.plugin_.postMessage({
       type: 'print',
     });
   },
 
   /**
    * @private
+   * Handle open PDF parameters. These parameters are mentioned in the URL
+   * and specify actions to be performed when opening PDF files.
+   * See http://crbug.com/64309 for details.
+   */
+  handleOpenPDFParams_: function() {
+    var originalUrl = this.streamDetails.originalUrl;
+    var hasParams = originalUrl.search('#');

[Lei Zhang, 2014/08/18 23:53:32]

hasParams -> paramIndex?

[Nikhil, 2014/08/19 05:28:08]

Done.

+    if (hasParams == -1)
+      return;
+
+    var paramTokens = originalUrl.substring(hasParams + 1).split('&');
+    var paramsDictionary = {};
+    for (var i = 0; i < paramTokens.length; ++i) {
+      var keyValueSplit = paramTokens[i].split('=');
+      if (keyValueSplit.length != 2)
+        continue;
+      paramsDictionary[keyValueSplit[0]] = keyValueSplit[1];
+    }
+
+    // Order is important as later actions can override the effects
+    // of previous actions.
+    if ('page' in paramsDictionary) {
+      // value is 1-based.
+      this.viewport_.goToPage(paramsDictionary['page'] - 1);

[Lei Zhang, 2014/08/18 23:53:32]

The current instance.cc code skips this if the page number is out of range.

[Nikhil, 2014/08/19 05:28:08]

Please let me know how do you think this should be handled -

[1] Ignore #page when page number is out of range (same as Firefox and
instance.cc).
[2] Maintain current behavior and clip the page (based on viewport_.goToPage).

I'm inclining towards [1], but don't have a strong preference.

+    }
+  },
+
+  /**
+   * @private
    * Update the loading progress of the document in response to a progress
    * message being received from the plugin.
    * @param {number} progress the progress as a percentage.
    */
   updateProgress_: function(progress) {
     this.progressBar_.progress = progress;
     if (progress == -1) {
       // Document load failed.
       this.errorScreen_.style.visibility = 'visible';
       this.sizer_.style.display = 'none';
       this.toolbar_.style.visibility = 'hidden';
       if (this.passwordScreen_.active) {
         this.passwordScreen_.deny();
         this.passwordScreen_.active = false;
       }
     } else if (progress == 100) {
       // Document load complete.
+      this.handleOpenPDFParams_();
       this.loaded = true;
       var loadEvent = new Event('pdfload');
       window.dispatchEvent(loadEvent);
       this.sendScriptingMessage_({
         type: 'documentLoaded'
       });
       if (this.lastViewportPosition_)
         this.viewport_.position = this.lastViewportPosition_;
     }
   },
@@ skipping 244 matching lines @@
 
   /**
    * @type {Viewport} the viewport of the PDF viewer.
    */
   get viewport() {
     return this.viewport_;
   }
 };
 
 var viewer = new PDFViewer();