OOP PDF - Add support for "page" open pdf parameter

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 <include src="../../../../ui/webui/resources/js/util.js">
 <include src="pdf_scripting_api.js">
 <include src="viewport.js">
 
@@ skipping 247 matching lines @@
    * Notify the plugin to print.
    */
   print_: function() {
     this.plugin_.postMessage({
       type: 'print',
     });
   },
 
   /**
    * @private
+   * Handle open PDF parameters.

[raymes, 2014/08/18 00:39:34]

nit: Maybe we can elaborate on the comment saying that all these parameters are
contained in the URL and include a link to the spec?

[Nikhil, 2014/08/18 04:53:32]

Done.

+   */
+  handleOpenPDFParams_: function() {
+    var originalUrl = this.streamDetails.originalUrl;
+    var hasParams = originalUrl.search('#');
+    if (hasParams == -1)
+      return;
+
+    var paramTokens = originalUrl.substring(hasParams + 1).split('&');
+    var paramsDictionary = {};
+    for (var i = 0; i < paramTokens.length; ++i) {
+      var keyValueSplit = paramTokens[i].split('=');
+      if (keyValueSplit.length != 2)
+        continue;
+      paramsDictionary[keyValueSplit[0]] = keyValueSplit[1];
+    }
+
+    // Order is important as later actions can override the effects
+    // of previous actions.
+    if ('page' in paramsDictionary) {
+      // value is 1-based.
+      this.viewport_.goToPage(paramsDictionary['page'] - 1);
+    }
+  },
+
+  /**
+   * @private
    * Update the loading progress of the document in response to a progress
    * message being received from the plugin.
    * @param {number} progress the progress as a percentage.
    */
   updateProgress_: function(progress) {
     this.progressBar_.progress = progress;
     if (progress == -1) {
       // Document load failed.
       this.errorScreen_.style.visibility = 'visible';
       this.sizer_.style.display = 'none';
       this.toolbar_.style.visibility = 'hidden';
       if (this.passwordScreen_.active) {
         this.passwordScreen_.deny();
         this.passwordScreen_.active = false;
       }
     } else if (progress == 100) {
       // Document load complete.
+      this.handleOpenPDFParams_();

[Nikhil, 2014/08/16 10:24:01]

Is there a way to check whether we are in PrintPreview mode or not? This call
should be protected by such a check.

[Nikhil, 2014/08/17 16:53:45]

Maybe I can introduce isPrintPreview() here? Similar to
OutOfProcessInstance::IsPrintPreview()
https://code.google.com/p/chromium/codesearch#chromium/src/pdf/out_of_process...

[raymes, 2014/08/18 00:39:34]

I think it should be ok not to do any check here. The reason is that the URL
should never contain these parameters in print preview mode. Let's leave out the
check for now :)

[Nikhil, 2014/08/18 04:53:32]

Acknowledged.

       this.loaded = true;
       var loadEvent = new Event('pdfload');
       window.dispatchEvent(loadEvent);
       this.sendScriptingMessage_({
         type: 'documentLoaded'
       });
       if (this.lastViewportPosition_)
         this.viewport_.position = this.lastViewportPosition_;
     }
   },
@@ skipping 244 matching lines @@
 
   /**
    * @type {Viewport} the viewport of the PDF viewer.
    */
   get viewport() {
     return this.viewport_;
   }
 };
 
 var viewer = new PDFViewer();