OOP PDF - Add support for "page" open pdf parameter

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <algorithm>  // for min/max()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 114 matching lines @@
 const char kJSNavigateType[] = "navigate";
 const char kJSNavigateUrl[] = "url";
 const char kJSNavigateNewTab[] = "newTab";
 // Open the email editor with the given parameters (Plugin -> Page)
 const char kJSEmailType[] = "email";
 const char kJSEmailTo[] = "to";
 const char kJSEmailCc[] = "cc";
 const char kJSEmailBcc[] = "bcc";
 const char kJSEmailSubject[] = "subject";
 const char kJSEmailBody[] = "body";
+// Handle open PDF parameters.
+const char kJSHandleOpenPDFParams[] = "openPDFParams";
 
 const int kFindResultCooldownMs = 100;
 
 const double kMinZoom = 0.01;
 
 namespace {
 
 static const char kPPPPdfInterface[] = PPP_PDF_INTERFACE_1;
 
 PP_Var GetLinkAtPosition(PP_Instance instance, PP_Point point) {
@@ skipping 922 matching lines @@
   // Clear focus state for OSK.
   FormTextFieldFocusChange(false);
 
   DCHECK(document_load_state_ == LOAD_STATE_LOADING);
   document_load_state_ = LOAD_STATE_COMPLETE;
   UserMetricsRecordAction("PDF.LoadSuccess");
 
   // Note: If we are in print preview mode the scroll location is retained
   // across document loads so we don't want to scroll again and override it.
   if (!IsPrintPreview()) {
-    int initial_page = GetInitialPage(url_);
-    if (initial_page >= 0)
-      ScrollToPage(initial_page);
+    pp::VarDictionary message;
+    message.Set(pp::Var(kType), pp::Var(kJSHandleOpenPDFParams));
+    PostMessage(message);

[raymes, 2014/08/15 01:07:18]

I don't think we need to add this new message type.

[Nikhil, 2014/08/16 10:24:01]

Done.

   } else {
     AppendBlankPrintPreviewPages();
     OnGeometryChanged(0, 0);
   }
 
   pp::VarDictionary message;
   message.Set(pp::Var(kType), pp::Var(kJSLoadProgressType));
   message.Set(pp::Var(kJSProgressPercentage), pp::Var(100)) ;
   PostMessage(message);
 
@@ skipping 207 matching lines @@
 
   const PPB_URLLoaderTrusted* trusted_interface =
       reinterpret_cast<const PPB_URLLoaderTrusted*>(
           pp::Module::Get()->GetBrowserInterface(
               PPB_URLLOADERTRUSTED_INTERFACE));
   if (trusted_interface)
     trusted_interface->GrantUniversalAccess(loader.pp_resource());
   return loader;
 }
 
 int OutOfProcessInstance::GetInitialPage(const std::string& url) {

[raymes, 2014/08/15 01:07:18]

I think we can get rid of this entire function from this file, hooray!

[Nikhil, 2014/08/16 10:24:01]

Done.

   size_t found_idx = url.find('#');
   if (found_idx == std::string::npos)
     return -1;
 
   const std::string& ref = url.substr(found_idx + 1);
   std::vector<std::string> fragments;
   Tokenize(ref, kDelimiters, &fragments);
 
   // Page number to return, zero-based.
   int page = -1;
@@ skipping 96 matching lines @@
 pp::Point OutOfProcessInstance::BoundScrollOffsetToDocument(
     const pp::Point& scroll_offset) {
   int max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();
   int x = std::max(std::min(scroll_offset.x(), max_x), 0);
   int max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
   int y = std::max(std::min(scroll_offset.y(), max_y), 0);
   return pp::Point(x, y);
 }
 
 }  // namespace chrome_pdf