Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 476733002: Deprecte LoweringBuilder in favor of Reducer. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Deprecate LoweringBuilder in favor of Reducer. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -138 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 3 chunks +4 lines, -10 lines 0 comments Download
D src/compiler/lowering-builder.h View 1 chunk +0 lines, -38 lines 0 comments Download
D src/compiler/lowering-builder.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +4 lines, -8 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 3 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-14 12:00:33 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-14 12:01:48 UTC) #2
Michael Starzinger
6 years, 4 months ago (2014-08-14 12:24:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23128 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698