Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 476713003: Remove fOrigFontID from SkScalerContextRec. (Closed)

Created:
6 years, 4 months ago by bungeman-skia
Modified:
6 years, 4 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Project:
skia
Visibility:
Public.

Description

Remove fOrigFontID from SkScalerContextRec. With the recent Android changes and removal of chaining, this is no longer used. Committed: https://skia.googlesource.com/skia/+/ec730b9cafaa3b2a4df7e7ceb3ab50601796fbe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/core/SkPaint.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkScalerContext.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bungeman-skia
6 years, 4 months ago (2014-08-14 21:19:07 UTC) #1
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-14 22:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/476713003/1
6 years, 4 months ago (2014-08-14 22:50:40 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-14 22:50:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 04:50:47 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 4 months ago (2014-08-15 04:50:48 UTC) #6
djsollen
lgtm
6 years, 4 months ago (2014-08-15 12:41:37 UTC) #7
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-15 14:09:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/476713003/1
6 years, 4 months ago (2014-08-15 14:10:12 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 14:57:40 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (1) as ec730b9cafaa3b2a4df7e7ceb3ab50601796fbe5

Powered by Google App Engine
This is Rietveld 408576698