Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 476693002: Remove unused CSSPrimitiveValue::CSS_PARSER_{OPERATOR,INTEGER,IDENTIFIER} (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pp6
Project:
blink
Visibility:
Public.

Description

Remove unused CSSPrimitiveValue::CSS_PARSER_{OPERATOR,INTEGER,IDENTIFIER} CSS_PARSER_INTEGER is only used as an alias for CSS_NUMBER, and the enums CSS_PARSER_OPERATOR and CSS_PARSER_IDENTIFIER are both unused. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -54 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 6 chunks +1 line, -11 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 chunks +1 line, -10 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 13 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Timothy Loh
(depends on removing CSSParserValue::createCSSValue, which used these: https://codereview.chromium.org/470903003/)
6 years, 4 months ago (2014-08-14 09:00:42 UTC) #1
eseidel
lgtm
6 years, 4 months ago (2014-08-14 17:27:17 UTC) #2
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-15 05:19:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/476693002/1
6 years, 4 months ago (2014-08-15 05:20:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-15 06:27:39 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 06:58:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180334

Powered by Google App Engine
This is Rietveld 408576698