Issue 476673002: Remove unused flag MediaQueryExp::isInteger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476673002: Remove unused flag MediaQueryExp::isInteger (Closed)

Created:
6 years, 4 months ago by Timothy Loh

Modified:
6 years, 4 months ago

Reviewers:
Yoav Weiss

CC:
blink-reviews, kenneth.christiansen, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@pp5

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove unused flag MediaQueryExp::isInteger Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180266

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	Source/core/css/MediaQueryExp.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	Source/core/css/MediaQueryExp.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yoav Weiss

On 2014/08/14 08:40:10, Timothy Loh wrote: Yeah, the actual int validation happens in MediaQueryExp using ...

6 years, 4 months ago (2014-08-14 08:48:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/476673002/1

6 years, 4 months ago (2014-08-14 08:50:01 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 4 months ago (2014-08-14 12:19:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180266

Expand Messages | Collapse Messages