Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 476663002: Gracefully handle property enumeration over deleted plugins. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Gracefully handle property enumeration over deleted plugins. R=haraken BUG=397473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A LayoutTests/plugins/plugin-destroyed-enumerate.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/plugins/plugin-destroyed-enumerate-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-14 08:43:22 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-14 08:57:02 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-14 09:10:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/476663002/1
6 years, 4 months ago (2014-08-14 09:11:24 UTC) #4
sof
On 2014/08/14 08:57:02, haraken wrote: > LGTM Thanks; looks like this bug has been there ...
6 years, 4 months ago (2014-08-14 09:33:41 UTC) #5
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-14 13:40:33 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-14 14:39:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/476663002/1
6 years, 4 months ago (2014-08-14 14:40:26 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:41:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 180274

Powered by Google App Engine
This is Rietveld 408576698