Issue 476653002: Revert of Fix regression introduced in r289434 - I missed the test_type.

Issue 476653002: Revert of Fix regression introduced in r289434 - I missed the test_type. (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.

Modified:
6 years, 4 months ago

Reviewers:
Dirk Pranke, tonyg

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Project:
tools

Visibility:
Public.

More Reviews

Description

Revert of Fix regression introduced in r289434 - I missed the test_type. (patchset #1 of https://codereview.chromium.org/466203005/) Reason for revert: Reverting telemetry-related changes because of breakages like http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30795/steps/telemetry_unittests/logs/stdio . Please watch the waterfall after applying the change. Original issue's description: > Fix regression introduced in r289434 - I missed the test_type. > > We need to specify the '--test-type' field in the telemetry* > unittests, and I missed that from the recipe. > > TBR=tonyg@chromium.org > BUG=323212 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289446 TBR=tonyg@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=323212 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289490

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -38 lines)			Patch
M	scripts/slave/recipe_modules/chromium/api.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	scripts/slave/recipes/chromium.expected/buildnumber_zero.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/dynamic_gtest.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Created Revert of Fix regression introduced in r289434 - I missed the test_type.

6 years, 4 months ago (2014-08-14 08:18:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/476653002/1

6 years, 4 months ago (2014-08-14 08:18:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (1) as 289490

Expand Messages | Collapse Messages