chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm - Issue 476643002: Bookmark context menu "Add folder..." allows to create folder with empty name(empty string).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

Issue 476643002: Bookmark context menu "Add folder..." allows to create folder with empty name(empty string). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

index bffa889634b7a60c419fa5ead1bfc0678c4c8cbf..778641f88d4d0b4a90b9b2ffd764a1daec63d0f8 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

@@ -97,6 +97,8 @@

- (IBAction)ok:(id)sender {

NSString* name = [nameField_ stringValue];

+ if (![name length])

Alexei Svitkine (slow) 2014/08/14 19:27:11 Nit: == 0 instead

siba.samal 2014/08/16 05:30:47 Done.

+ name = l10n_util::GetNSStringWithFixup(IDS_BOOKMARK_EDITOR_NEW_FOLDER_NAME);

BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);

if (node_) {

model->SetTitle(node_, base::SysNSStringToUTF16(name));

« no previous file with comments | « no previous file | no next file » | no next file with comments »