Speculative fix for BrowserOptionsOverlayWebUITest.testNavigationInBackground

chrome/browser/ui/webui/options/browser_options_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * TestFixture for browser options WebUI testing.
  * @extends {testing.Test}
  * @constructor
  */
 function BrowserOptionsWebUITest() {}
@@ skipping 23 matching lines @@
  * @extends {testing.Test}
  * @constructor
  */
 function BrowserOptionsOverlayWebUITest() {}
 
 BrowserOptionsOverlayWebUITest.prototype = {
   __proto__: testing.Test.prototype,
 
   /** @override */
   browsePreload: 'chrome://chrome/settings/autofill',
+
+  /** @override */
+  isAsync: true,
 };
 
 TEST_F('BrowserOptionsOverlayWebUITest', 'testNavigationInBackground',
     function() {
   assertEquals(this.browsePreload, document.location.href);
-  expectTrue($('navigation').classList.contains('background'));
+
+  // Speculative fix for 403627.

[Evan Stade, 2014/08/14 17:10:02]

this comment should read: wait for the message to be posted to the Uber page

[michaelpg, 2014/08/14 23:02:52]

Done.

+  if (!$('navigation').classList.contains('background')) {

[Evan Stade, 2014/08/14 17:10:02]

nit:

if ($('navigation').classList.contains('background')) {
  testDone();
  return;
}

[...]

[michaelpg, 2014/08/14 23:02:52]

Done.

+    window.addEventListener('message', function(e) {
+      if (e.data.method == 'beginInterceptingEvents') {
+        window.setTimeout(function() {
+          assertTrue($('navigation').classList.contains('background'));
+          testDone();
+        });
+      }
+    });
+  } else {
+    testDone();
+  }
 });
 
 /**
  * @extends {testing.Test}
  * @constructor
  */
 function BrowserOptionsFrameWebUITest() {}
 
 BrowserOptionsFrameWebUITest.prototype = {
   __proto__: testing.Test.prototype,
@@ skipping 18 matching lines @@
   __proto__: testing.Test.prototype,
 
   /** @override */
   browsePreload: 'chrome://settings-frame/autofill',
 };
 
 TEST_F('AdvancedSettingsWebUITest', 'testAdvancedSettingsShown', function() {
   assertEquals(this.browsePreload, document.location.href);
   expectFalse($('advanced-settings').hidden);
 });