Speculative fix for BrowserOptionsOverlayWebUITest.testNavigationInBackground

Speculative fix for BrowserOptionsOverlayWebUITest.testNavigationInBackground

BrowserOptionsOverlayWebUITest.testNavigationInBackground fails on DrMemory
bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%2811%29/builds/476

This changes the test to wait if it detects that the appropriate message has not yet been
sent to the uber page. This ensures that we are only testing the finalized state of the
page.  If the test times out, that would indicate that the problem lies elsewhere.

BUG=403627
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290049

[michaelpg, 2014-08-14 04:37:31]

Hey Evan, I'd appreciate it if you could you take a look at this failure and let
me know if you've seen something like this before in uberland, and whether you
think making this test async might help.

[Evan Stade, 2014-08-14 17:10:03]

Code looks OK. But most of your CL description belongs in one of:

a) the bug report
b) the comment thread of this CL

I don't think comments like[1] belong in the commit log.

[1] "So I'm not understanding how that chain could fail unless
Window.postMessage is pausing until the test runs
(although on my machine the message posts before the test case starts)."

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/browser_options_browsertest.js (right):

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_browsertest.js:53: //
Speculative fix for 403627.
this comment should read: wait for the message to be posted to the Uber page

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_browsertest.js:54: if
(!$('navigation').classList.contains('background')) {
nit:

if ($('navigation').classList.contains('background')) {
  testDone();
  return;
}

[...]

[michaelpg, 2014-08-14 23:02:53]

> Code looks OK. But most of your CL description belongs in one of:
> 
> a) the bug report
> b) the comment thread of this CL
> 
> I don't think comments like[1] belong in the commit log.

Definitely. I just wanted to get your thoughts before continuing down this path
and then update the description to something more definitive.

In the future I'll put something like that in the bug instead of the description
and
then reference it from the comments here.

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/browser_options_browsertest.js (right):

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_browsertest.js:53: //
Speculative fix for 403627.
On 2014/08/14 17:10:02, Evan Stade wrote:
> this comment should read: wait for the message to be posted to the Uber page

Done.

https://codereview.chromium.org/476573002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_browsertest.js:54: if
(!$('navigation').classList.contains('background')) {
On 2014/08/14 17:10:02, Evan Stade wrote:
> nit:
> 
> if ($('navigation').classList.contains('background')) {
>   testDone();
>   return;
> }
> 
> [...]

Done.

[Evan Stade, 2014-08-15 15:42:06]

lgtm

[michaelpg, 2014-08-15 17:47:13]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-08-15 17:52:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/476573002/20001

[commit-bot: I haz the power, 2014-08-15 23:32:29]

Committed patchset #2 (20001) as 290049